netdev - Re: [PATCH net] veth: Fix vlan_features so as to be able to use stacked vlan interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140220.021641.1381577589162092169.davem@davemloft.net>
Date:	Thu, 20 Feb 2014 02:16:41 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	makita.toshiaki@....ntt.co.jp
Cc:	fbl@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] veth: Fix vlan_features so as to be able to use
 stacked vlan interfaces

From: Toshiaki Makita <makita.toshiaki@....ntt.co.jp>
Date: Tue, 18 Feb 2014 21:20:08 +0900

> Even if we create a stacked vlan interface such as veth0.10.20, it sends
> single tagged frames (tagged with only vid 10).
> Because vlan_features of a veth interface has the
> NETIF_F_HW_VLAN_[CTAG/STAG]_TX bits, veth0.10 also has that feature, so
> dev_hard_start_xmit(veth0.10) doesn't call __vlan_put_tag() and
> vlan_dev_hard_start_xmit(veth0.10) overwrites vlan_tci.
> This prevents us from using a combination of 802.1ad and 802.1Q
> in containers, etc.
> 
> Signed-off-by: Toshiaki Makita <makita.toshiaki@....ntt.co.jp>

Applied and queued up for -stable.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html