netdev - Re: [PATCH net] tun: remove bogus hardware vlan acceleration flags from vlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140220.021649.1758178843439700559.davem@davemloft.net>
Date:	Thu, 20 Feb 2014 02:16:49 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	makita.toshiaki@....ntt.co.jp
Cc:	fernando@....ntt.co.jp, maxk@....qualcomm.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH net] tun: remove bogus hardware vlan acceleration flags
 from vlan_features

From: Toshiaki Makita <makita.toshiaki@....ntt.co.jp>
Date: Tue, 18 Feb 2014 21:20:09 +0900

> From: Fernando Luis Vazquez Cao <fernando@....ntt.co.jp>
> 
> Even though only the outer vlan tag can be HW accelerated in the transmission
> path, in the TUN/TAP driver vlan_features mirrors hw_features, which happens
> to have the NETIF_F_HW_VLAN_?TAG_TX flags set. Because of this, during packet
> tranmisssion through a stacked vlan device dev_hard_start_xmit, (incorrectly)
> assuming that the vlan device supports hardware vlan acceleration, does not
> add the vlan header to the skb payload and the inner vlan tags are lost
> (vlan_tci contains the outer vlan tag when userspace reads the packet from
> the tap device).
> 
> Signed-off-by: Fernando Luis Vazquez Cao <fernando@....ntt.co.jp>
> Signed-off-by: Toshiaki Makita <makita.toshiaki@....ntt.co.jp>

Applied and queued up for -stable.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html