netdev - RE: [PATCH net-next V2 1/2] net/mlx4: Set number of RX rings in a utility function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <063D6719AE5E284EB5DD2968C1650D6D0F6C800B@AcuExch.aculab.com>
Date:	Fri, 21 Feb 2014 11:01:17 +0000
From:	David Laight <David.Laight@...LAB.COM>
To:	'Amir Vadai' <amirv@...lanox.com>,
	"David S. Miller" <davem@...emloft.net>
CC:	Or Gerlitz <ogerlitz@...lanox.com>,
	Yevgeny Petrilin <yevgenyp@...lanox.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Ido Shamay <idos@...lanox.com>
Subject: RE: [PATCH net-next V2 1/2] net/mlx4: Set number of RX rings in a
 utility function

From: Amir Vadai
> From: Ido Shamay <idos@...lanox.com>
> 
> mlx4_en_add() is too long.
> Moving set number of RX rings to a utiltity function to improve
> readability and modulization of the code.
...
> --- a/drivers/net/ethernet/mellanox/mlx4/en_rx.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/en_rx.c
> @@ -318,6 +318,28 @@ static void mlx4_en_free_rx_buf(struct mlx4_en_priv *priv,
>  	}
>  }
> 
> +void mlx4_en_set_num_rx_rings(struct mlx4_en_dev *mdev)
> +{

Should be static.

	David



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html