netdev - Re: [PATCH net-next V2 1/2] net/mlx4: Set number of RX rings in a utility function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53073B87.2050303@dev.mellanox.co.il>
Date:	Fri, 21 Feb 2014 13:41:59 +0200
From:	Ido Shamai <idos@....mellanox.co.il>
To:	David Laight <David.Laight@...LAB.COM>,
	'Amir Vadai' <amirv@...lanox.com>,
	"David S. Miller" <davem@...emloft.net>
CC:	Or Gerlitz <ogerlitz@...lanox.com>,
	Yevgeny Petrilin <yevgenyp@...lanox.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Ido Shamay <idos@...lanox.com>
Subject: Re: [PATCH net-next V2 1/2] net/mlx4: Set number of RX rings in a
 utility function

On 2/21/2014 1:01 PM, David Laight wrote:
> From: Amir Vadai
>> From: Ido Shamay <idos@...lanox.com>
>>
>> mlx4_en_add() is too long.
>> Moving set number of RX rings to a utiltity function to improve
>> readability and modulization of the code.
> ...
>> --- a/drivers/net/ethernet/mellanox/mlx4/en_rx.c
>> +++ b/drivers/net/ethernet/mellanox/mlx4/en_rx.c
>> @@ -318,6 +318,28 @@ static void mlx4_en_free_rx_buf(struct mlx4_en_priv *priv,
>>   	}
>>   }
>>
>> +void mlx4_en_set_num_rx_rings(struct mlx4_en_dev *mdev)
>> +{
>
> Should be static.
It's not in the same c file.
Function was defined in en_rx.c for better modularization.
It may be in use by other files (ethtool.c) in the future
Ido
>
> 	David
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html