netdev - RE: [PATCH net 4/5] be2net: wait longer to reap TX compls in be

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <063D6719AE5E284EB5DD2968C1650D6D0F6C9608@AcuExch.aculab.com>
Date:	Mon, 24 Feb 2014 09:31:15 +0000
From:	David Laight <David.Laight@...LAB.COM>
To:	'Somnath Kotur' <somnath.kotur@...lex.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:	"davem@...emloft.net" <davem@...emloft.net>,
	Vasundhara Volam <vasundhara.volam@...lex.com>,
	Sathya Perla <sathya.perla@...lex.com>
Subject: RE: [PATCH net 4/5] be2net: wait longer to reap TX compls in
 be_close()

From: Of Somnath Kotur
> be_close() currently waits for a max of 200ms to receive all pending
> TX compls. This timeout value was roughly calcuated based on 10G
> transmission speeds and the TX queue depth. This timeout may not be
> enough when the link is operating at lower speeds or in
> multi-channel/SR-IOV configs with TX-rate limiting setting.
> Increase the timeout to 2000ms and also bail-out if there is
> a HW-error.

What about monitoring whether transmits are actually completing,
and giving up if none are completed within a suitable time period?

	David



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html