netdev - Re: [PATCH net v2 2/2] bonding: Fix RTNL: assertion failed at net/core/rtnetlink.c for ab arp monitor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140225.173401.1376027261153019177.davem@davemloft.net>
Date:	Tue, 25 Feb 2014 17:34:01 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	dingtianhong@...wei.com
Cc:	fubar@...ibm.com, vfalico@...hat.com, andy@...yhouse.net,
	cwang@...pensource.com, jiri@...nulli.us, thomas@...nzmann.de,
	eric.dumazet@...il.com, sfeldma@...ulusnetworks.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH net v2 2/2] bonding: Fix RTNL: assertion failed at
 net/core/rtnetlink.c for ab arp monitor

From: Ding Tianhong <dingtianhong@...wei.com>
Date: Wed, 19 Feb 2014 17:05:11 +0800

> -static bool bond_ab_arp_probe(struct bonding *bond)
> +static int bond_ab_arp_probe(struct bonding *bond)
>  {
>  	struct slave *slave, *before = NULL, *new_slave = NULL,
> -		     *curr_arp_slave, *curr_active_slave;
> +		     *curr_arp_slave = rcu_dereference(bond->current_arp_slave),
> +		     *curr_active_slave = rcu_dereference(bond->curr_active_slave);
>  	struct list_head *iter;
>  	bool found = false;
> -
> -	rcu_read_lock();
> -	curr_arp_slave = rcu_dereference(bond->current_arp_slave);
> -	curr_active_slave = rcu_dereference(bond->curr_active_slave);
> +	int slave_should_notify = 0;

Likewise use bool here and then you don't have to change the return type
of this function.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html