netdev - Re: [PATCH net v2 1/2] bonding: Fix RTNL: assertion failed at net/core/rtnetlink.c for 802.3ad mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <530D47B8.1010609@huawei.com>
Date:	Wed, 26 Feb 2014 09:47:36 +0800
From:	Ding Tianhong <dingtianhong@...wei.com>
To:	David Miller <davem@...emloft.net>
CC:	<fubar@...ibm.com>, <vfalico@...hat.com>, <andy@...yhouse.net>,
	<cwang@...pensource.com>, <jiri@...nulli.us>,
	<thomas@...nzmann.de>, <eric.dumazet@...il.com>,
	<sfeldma@...ulusnetworks.com>, <netdev@...r.kernel.org>
Subject: Re: [PATCH net v2 1/2] bonding: Fix RTNL: assertion failed at net/core/rtnetlink.c
 for 802.3ad mode

On 2014/2/26 6:32, David Miller wrote:
> From: Ding Tianhong <dingtianhong@...wei.com>
> Date: Wed, 19 Feb 2014 17:05:10 +0800
> 
>> @@ -2062,6 +2062,7 @@ void bond_3ad_state_machine_handler(struct work_struct *work)
>>  	struct list_head *iter;
>>  	struct slave *slave;
>>  	struct port *port;
>> +	int slave_should_notify = 0;
> 
> Please use bool, true/false, for slave_should_notify.
> 
> Thanks.
> 
> .
> 

Yes, thanks, also fix the 2 patch.

Ding 


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html