netdev - Re: [PATCH v6 net-next 1/2] net: add skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140226.150246.2032724506200600118.davem@davemloft.net>
Date:	Wed, 26 Feb 2014 15:02:46 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	stephen@...workplumber.org, ja@....bg, ycheng@...gle.com,
	netdev@...r.kernel.org, ncardwell@...gle.com, brakmo@...gle.com
Subject: Re: [PATCH v6 net-next 1/2] net: add skb_mstamp infrastructure

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Mon, 24 Feb 2014 22:22:04 -0800

> Instead of :
> 
> 	u64 t0, t1;
> 
> 	t0 = ktime_get();
> 	// stuff
> 	t1 = ktime_get();
> 	delta_us = ktime_us_delta(t1, t0);
> 
> use :
> 	struct skb_mstamp t0, t1;
> 
> 	skb_mstamp_get(&t0);
> 	// stuff
> 	skb_mstamp_get(&t1);
> 	delta_us = skb_mstamp_us_delta(&t1, &t0);
 ...
> +/**
> + * skb_mstamp_delta - compute the difference in usec between two skb_mstamp
> + * @t1: pointer to oldest sample
> + * @t0: pointer to newest sample
> + */
> +static inline u32 skb_mstamp_us_delta(const struct skb_mstamp *t1,
> +				      const struct skb_mstamp *t0)

Maybe your definition of "newest" is different from mine, to me it
means most recently sampled.  And if so, your t1 and t0 descriptions
seem reversed.

Please fix this and resubmit with Neal's ACK etc.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html