netdev - Re: [PATCH v6 net-next 1/2] net: add skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1393446562.26794.0.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Wed, 26 Feb 2014 12:29:22 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	stephen@...workplumber.org, ja@....bg, ycheng@...gle.com,
	netdev@...r.kernel.org, ncardwell@...gle.com, brakmo@...gle.com
Subject: Re: [PATCH v6 net-next 1/2] net: add skb_mstamp infrastructure

On Wed, 2014-02-26 at 15:02 -0500, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@...il.com>

> > + * skb_mstamp_delta - compute the difference in usec between two skb_mstamp
> > + * @t1: pointer to oldest sample
> > + * @t0: pointer to newest sample
> > + */
> > +static inline u32 skb_mstamp_us_delta(const struct skb_mstamp *t1,
> > +				      const struct skb_mstamp *t0)
> 
> Maybe your definition of "newest" is different from mine, to me it
> means most recently sampled.  And if so, your t1 and t0 descriptions
> seem reversed.
> 
> Please fix this and resubmit with Neal's ACK etc.

Humpf, right you are, I'll send a v6, thanks !


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html