netdev - Re: [PATCH 1/1] AX88179_178A: Add VID:DID for Lenovo OneLinkDock Gigabit LAN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87lhwx7f19.fsf@nemi.mork.no>
Date:	Wed, 26 Feb 2014 22:14:10 +0100
From:	Bjørn Mork <bjorn@...k.no>
To:	David Miller <davem@...emloft.net>
Cc:	freddy@...x.com.tw, netdev@...r.kernel.org,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] AX88179_178A: Add VID:DID for Lenovo OneLinkDock Gigabit LAN

David Miller <davem@...emloft.net> writes:

> From: Bjørn Mork <bjorn@...k.no>
> Date: Wed, 26 Feb 2014 13:13:12 +0100
>
>> freddy@...x.com.tw writes:
>> 
>>> From: Freddy Xin <freddy@...x.com.tw>
>>>
>>> Add VID:DID for Lenovo OneLinkDock Gigabit LAN
>> 
>> This is the same patch Keith Packard sent, but with a slighly different
>> description.  I take that as another proof that we should not attempt to
>> describe devices in these drivers.  Describe the driver instead.
>
> Are you saying that this patch needs to be implemented differently?

No, sorry for being confusing.  The patch is fine.  But Keith sent it
first...

The other comment is more of a personal opinion on the driver style.  In
any case, it's something that can be fixed up later. If at all.


Bjørn
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html