netdev - Re: [PATCH net] bna: don't disable VLAN tag stripping in promisc mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140227195923.GA2901@minipsycho.orion>
Date:	Thu, 27 Feb 2014 20:59:23 +0100
From:	Jiri Pirko <jiri@...nulli.us>
To:	Ivan Vecera <ivecera@...hat.com>
Cc:	netdev@...r.kernel.org, Rasesh Mody <rmody@...cade.com>
Subject: Re: [PATCH net] bna: don't disable VLAN tag stripping in promisc mode

Thu, Feb 27, 2014 at 07:17:22PM CET, ivecera@...hat.com wrote:
>The recent commit "fe1624c bna: RX Filter Enhancements" disables
>VLAN tag stripping if the NIC is in promiscuous mode. Received VLAN tagged
>packets are recognized by the driver via BNA_CQ_EF_VLAN flag and for such
>packets the driver calls __vlan_hwaccel_put_tag(). The problem is the HW
>marks the tagged packets with this flags also when the stripping is
>disabled and thus __vlan_hwaccel_put_tag() should not be called for them.
>
>A solution can be to call __vlan_hwaccel_put_tag() only when stripping is
>enabled or to leave VLAN stripping engine enabled. The 2nd restores the
>previous behavior and is IMHO better.
>
>Cc: Rasesh Mody <rmody@...cade.com>
>Signed-off-by: Ivan Vecera <ivecera@...hat.com>
Reviewed-by: Jiri Pirko <jiri@...nulli.us>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html