netdev - Re: [PATCHv2 net-next 18/31] iw_cxgb4: ignore read reponse type 1 CQEs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 03 Mar 2014 21:49:06 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Hariprasad Shenai <hariprasad@...lsio.com>, netdev@...r.kernel.org,
	linux-rdma@...r.kernel.org
CC:	davem@...emloft.net, roland@...estorage.com, kumaras@...lsio.com,
	dm@...lsio.com, swise@...ngridcomputing.com, leedom@...lsio.com,
	santosh@...lsio.com, nirranjan@...lsio.com
Subject: Re: [PATCHv2 net-next 18/31] iw_cxgb4: ignore read reponse type 1
 CQEs.

Hello.

On 03/03/2014 09:41 AM, Hariprasad Shenai wrote:

> From: Steve Wise <swise@...ngridcomputing.com>

> These are generated by HW in some error cases and need to be
> silently discarded.

> Signed-off-by: Steve Wise <swise@...ngridcomputing.com>
> ---
>   drivers/infiniband/hw/cxgb4/cq.c |   20 ++++++++++++++++++++
>   1 files changed, 20 insertions(+), 0 deletions(-)

> diff --git a/drivers/infiniband/hw/cxgb4/cq.c b/drivers/infiniband/hw/cxgb4/cq.c
> index 59f7601..e310762 100644
> --- a/drivers/infiniband/hw/cxgb4/cq.c
> +++ b/drivers/infiniband/hw/cxgb4/cq.c
> @@ -366,6 +366,14 @@ void c4iw_flush_hw_cq(struct c4iw_cq *chp)
>   		if (CQE_OPCODE(hw_cqe) == FW_RI_READ_RESP) {
>
>   			/*
> +			 * If we have reached here because of async
> +			 * event or other error, and have egress error
> +			 * then drop
> +			 */

    The networking code multi-line comment style is:

/* bla
  * bla
  */

> +			if (CQE_TYPE(hw_cqe) == 1)
> +				goto next_cqe;
> +
> +			/*
>   			 * drop peer2peer RTR reads.
>   			 */
>   			if (CQE_WRID_STAG(hw_cqe) == 1)
> @@ -512,6 +520,18 @@ static int poll_cq(struct t4_wq *wq, struct t4_cq *cq, struct t4_cqe *cqe,
>   	if (RQ_TYPE(hw_cqe) && (CQE_OPCODE(hw_cqe) == FW_RI_READ_RESP)) {
>
>   		/*
> +		 * If we have reached here because of async
> +		 * event or other error, and have egress error
> +		 * then drop
> +		 */

    Likewise.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html