netdev - Re: [PATCHv2 net-next 16/31] iw_cxgb4: don't leak skb in c4iw_uld_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 03 Mar 2014 21:46:39 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Hariprasad Shenai <hariprasad@...lsio.com>, netdev@...r.kernel.org,
	linux-rdma@...r.kernel.org
CC:	davem@...emloft.net, roland@...estorage.com, kumaras@...lsio.com,
	dm@...lsio.com, swise@...ngridcomputing.com, leedom@...lsio.com,
	santosh@...lsio.com, nirranjan@...lsio.com
Subject: Re: [PATCHv2 net-next 16/31] iw_cxgb4: don't leak skb in c4iw_uld_rx_handler().

Hello.

On 03/03/2014 09:41 AM, Hariprasad Shenai wrote:

> From: Steve Wise <swise@...ngridcomputing.com>

> Signed-off-by: Steve Wise <swise@...ngridcomputing.com>
> ---
>   drivers/infiniband/hw/cxgb4/device.c |    4 +++-
>   1 files changed, 3 insertions(+), 1 deletions(-)

> diff --git a/drivers/infiniband/hw/cxgb4/device.c b/drivers/infiniband/hw/cxgb4/device.c
> index 9542ccc..f73fea4 100644
> --- a/drivers/infiniband/hw/cxgb4/device.c
> +++ b/drivers/infiniband/hw/cxgb4/device.c
> @@ -936,9 +936,11 @@ static int c4iw_uld_rx_handler(void *handle, const __be64 *rsp,
>   	opcode = *(u8 *)rsp;
>   	if (c4iw_handlers[opcode])
>   		c4iw_handlers[opcode](dev, skb);
> -	else
> +	else {
>   		pr_info("%s no handler opcode 0x%x...\n", __func__,
>   		       opcode);
> +		kfree_skb(skb);
> +	}

    Should have {} in both arms of the *if* statement now. See 
Documentation/CodingStyle.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html