[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <154e570c-599b-4e7d-ab7e-d08fc2ca2883@CMEXHTCAS2.ad.emulex.com>
Date: Tue, 4 Mar 2014 19:03:26 +0000
From: Ajit Khaparde <Ajit.Khaparde@...lex.Com>
To: Ivan Vecera <ivecera@...hat.com>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC: Sathya Perla <Sathya.Perla@...lex.Com>,
Subramanian Seetharaman <subbu.seetharaman@...lex.com>
Subject: RE: [PATCH net-next] be2net: do external loopback test only when it
is requested
> -----Original Message-----
> From: Ivan Vecera [mailto:ivecera@...hat.com]
> Sent: Tuesday, March 04, 2014 12:05 PM
> To: netdev@...r.kernel.org
> Cc: Sathya Perla; Subramanian Seetharaman; Ajit Khaparde
> Subject: [PATCH net-next] be2net: do external loopback test only when it is
> requested
>
> Cc: sathya.perla@...lex.com
> Cc: subbu.seetharaman@...lex.com
> Cc: ajit.khaparde@...lex.com
>
> Signed-off-by: Ivan Vecera <ivecera@...hat.com>
Acked-by: Ajit Khaparde <ajit.khaparde@...lex.com>
> ---
> drivers/net/ethernet/emulex/benet/be_ethtool.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/emulex/benet/be_ethtool.c
> b/drivers/net/ethernet/emulex/benet/be_ethtool.c
> index cf09d8f..957848f 100644
> --- a/drivers/net/ethernet/emulex/benet/be_ethtool.c
> +++ b/drivers/net/ethernet/emulex/benet/be_ethtool.c
> @@ -809,9 +809,12 @@ be_self_test(struct net_device *netdev, struct
> ethtool_test *test, u64 *data)
> &data[1]) != 0) {
> test->flags |= ETH_TEST_FL_FAILED;
> }
> - if (be_loopback_test(adapter,
> BE_ONE_PORT_EXT_LOOPBACK,
> - &data[2]) != 0) {
> - test->flags |= ETH_TEST_FL_FAILED;
> + if (test->flags & ETH_TEST_FL_EXTERNAL_LB) {
> + if (be_loopback_test(adapter,
> BE_ONE_PORT_EXT_LOOPBACK,
> + &data[2]) != 0) {
> + test->flags |= ETH_TEST_FL_FAILED;
> + }
> + test->flags |= ETH_TEST_FL_EXTERNAL_LB_DONE;
> }
> }
>
> --
> 1.8.3.2
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists