netdev - Re: [PATCH net-next] be2net: do external loopback test only when it is requested

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <531634F1.4070109@cogentembedded.com>
Date:	Tue, 04 Mar 2014 23:17:53 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Ivan Vecera <ivecera@...hat.com>, netdev@...r.kernel.org
CC:	sathya.perla@...lex.com, subbu.seetharaman@...lex.com,
	ajit.khaparde@...lex.com
Subject: Re: [PATCH net-next] be2net: do external loopback test only when
 it is requested

Hello.

On 03/04/2014 09:04 PM, Ivan Vecera wrote:

> Cc: sathya.perla@...lex.com
> Cc: subbu.seetharaman@...lex.com
> Cc: ajit.khaparde@...lex.com

> Signed-off-by: Ivan Vecera <ivecera@...hat.com>
> ---
>   drivers/net/ethernet/emulex/benet/be_ethtool.c | 9 ++++++---
>   1 file changed, 6 insertions(+), 3 deletions(-)

> diff --git a/drivers/net/ethernet/emulex/benet/be_ethtool.c b/drivers/net/ethernet/emulex/benet/be_ethtool.c
> index cf09d8f..957848f 100644
> --- a/drivers/net/ethernet/emulex/benet/be_ethtool.c
> +++ b/drivers/net/ethernet/emulex/benet/be_ethtool.c
> @@ -809,9 +809,12 @@ be_self_test(struct net_device *netdev, struct ethtool_test *test, u64 *data)
>   						&data[1]) != 0) {
>   			test->flags |= ETH_TEST_FL_FAILED;
>   		}
> -		if (be_loopback_test(adapter, BE_ONE_PORT_EXT_LOOPBACK,
> -						&data[2]) != 0) {
> -			test->flags |= ETH_TEST_FL_FAILED;
> +		if (test->flags & ETH_TEST_FL_EXTERNAL_LB) {
> +			if (be_loopback_test(adapter, BE_ONE_PORT_EXT_LOOPBACK,
> +					     &data[2]) != 0) {
> +				test->flags |= ETH_TEST_FL_FAILED;
> +			}

    {} not needed here, according to Documentation/CodingStyle. I'm surprised 
scripts/checkpatch.pl passed, it used to catch those.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html