netdev - Re: [PATCHv3 net-next 03/31] cxgb4: Rectify emitting messages about SGE Ingress DMA channels being potentially stuck

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 04 Mar 2014 23:22:12 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Joe Perches <joe@...ches.com>,
	Hariprasad Shenai <hariprasad@...lsio.com>
CC:	netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
	davem@...emloft.net, roland@...estorage.com, kumaras@...lsio.com,
	dm@...lsio.com, swise@...ngridcomputing.com, leedom@...lsio.com,
	santosh@...lsio.com, nirranjan@...lsio.com
Subject: Re: [PATCHv3 net-next 03/31] cxgb4: Rectify emitting messages about
 SGE Ingress DMA channels being potentially stuck

Hello.

On 03/04/2014 08:43 PM, Joe Perches wrote:

>> From: Kumar Sanghvi <kumaras@...lsio.com>

>> Based on original work by Casey Leedom <leedom@...lsio.com>

> trivial comments:

>> diff --git a/drivers/net/ethernet/chelsio/cxgb4/sge.c b/drivers/net/ethernet/chelsio/cxgb4/sge.c

>> @@ -2031,21 +2041,65 @@ static void sge_rx_timer_cb(unsigned long data)
> []
>> +		if (idma_same_state_cnt[i] < s->idma_1s_thresh) {
>> +			if (s->idma_stalled[i] >= SGE_IDMA_WARN_THRESH)
>> +				CH_WARN(adap, "SGE idma%d, queue%u,resumed after %d sec",

> Missing terminating '\n', probably better as:

> 				CH_WARN(adap, "SGE idma%d, queue%u, resumed after %d sec\n",

>> +		CH_WARN(adap, "SGE idma%u, queue%u, maybe stuck state%u %dsecs"
>> +			" (debug0=%#x, debug11=%#x)\n",

> Probably better with the format coalesced:

> 		CH_WARN(adap, "SGE idma%u, queue%u, maybe stuck state%u %dsecs (debug0=%#x, debug11=%#x)\n",

    Surely better, as otherwise it shouldn't pass scripts/checkpatch.pl.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html