netdev - Re: [PATCHv3 net-next 00/31] Misc. fixes for cxgb4 and iw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <165B3A81-646E-4AEB-A1CC-D7F3C255A870@chelsio.com>
Date:	Wed, 5 Mar 2014 12:51:49 -0800
From:	Casey Leedom <leedom@...lsio.com>
To:	Or Gerlitz <or.gerlitz@...il.com>
Cc:	Hariprasad S <hariprasad@...lsio.com>,
	David Miller <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	linux-rdma <linux-rdma@...r.kernel.org>,
	Roland Dreier <roland@...estorage.com>, kumaras@...lsio.com,
	dm@...lsio.com, Steve Wise <swise@...ngridcomputing.com>,
	santosh@...lsio.com, nirranjan@...lsio.com,
	Eli Cohen <eli@...lanox.com>
Subject: Re: [PATCHv3 net-next 00/31] Misc. fixes for cxgb4 and iw_cxgb4 


On Mar 5, 2014, at 11:59 AM, Casey Leedom <leedom@...lsio.com> wrote:

> 
> On Mar 5, 2014, at 11:52 AM, Or Gerlitz <or.gerlitz@...il.com> wrote:
> 
>> On Wed, Mar 5, 2014 at 9:46 PM, Casey Leedom <leedom@...lsio.com> wrote:
>> 
>> are you referring to constants defined in
>> drivers/net/ethernet/chelsio/cxgb4/t4_hw.h or other/more headers?
> 
>  t4_regs.h.  Strangely, when we submitted the driver, the very similar symbolic constant formats in t4_msg.h and t4fw_api.h weren’t targeted; just the ones in t4_regs.h.

  By the way, please don’t take this as in any way advocating that the symbolic constants in t4_msg.h and t4fw_api.h should also be changed in a way which is incompatible with out out-of-kernel development tree — our lives are hard enough already with the changes symbolic constants in t4_regs.h! :-)

Casey--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html