netdev - Re: [PATCH net-next] net_sched: htb: do not acquire qdisc lock in dump operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140306.172610.1610849095441712557.davem@davemloft.net>
Date:	Thu, 06 Mar 2014 17:26:10 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net_sched: htb: do not acquire qdisc lock in
 dump operations

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 05 Mar 2014 10:14:34 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> htb_dump() and htb_dump_class() do not strictly need to acquire
> qdisc lock to fetch qdisc and/or class parameters.
> 
> We hold RTNL and no changes can occur.
> 
> This reduces by 50% qdisc lock pressure while doing tc qdisc|class dump
> operations.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Yep, this looks like a valid locking removal.

Applied, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html