netdev - Re: [PATCH net] ipv6: don't set DST_NOCOUNT for remotely added routes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140306.173052.2036545218328254290.davem@davemloft.net>
Date:	Thu, 06 Mar 2014 17:30:52 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	sd@...asysnail.net
Cc:	netdev@...r.kernel.org, hannes@...essinduktion.org
Subject: Re: [PATCH net] ipv6: don't set DST_NOCOUNT for remotely added
 routes

From: Sabrina Dubroca <sd@...asysnail.net>
Date: Thu, 6 Mar 2014 22:03:17 +0100

> 2014-03-06, 15:27:15 -0500, David Miller wrote:
>> From: Sabrina Dubroca <sd@...asysnail.net>
>> Date: Thu,  6 Mar 2014 17:51:57 +0100
>> 
>> > DST_NOCOUNT should only be used if an authorized user adds routes
>> > locally. In case of routes which are added on behalf of router
>> > advertisments this flag must not get used as it allows an unlimited
>> > number of routes getting added remotely.
>> > 
>> > Signed-off-by: Sabrina Dubroca <sd@...asysnail.net>
>> > Acked-by: Hannes Frederic Sowa <hannes@...essinduktion.org>
>> > ---
>> > 
>> > Hannes suggested this for stable
>> 
>> This seems to conflict with the intentions of:
>> 
>> commit a3300ef4bbb1f1e33ff0400e1e6cf7733d988f4f
>> Author: Hannes Frederic Sowa <hannes@...essinduktion.org>
>> Date:   Sat Dec 7 03:33:45 2013 +0100
>> 
>>     ipv6: don't count addrconf generated routes against gc limit
>> 
>> If not, why not?
> 
> These are not the same routes. The commit you mention is for the
> routes added to the loopback device in the local table (limited by
> max_addresses as the log says).
> 
> This patch limits the number of "real" routes that can be added,
> which is currently unlimited.

Ok, I see the difference now, thanks for explaining.

Applied and queued up for -stable.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html