netdev - Re: [PATCH net-next v2 1/6] tipc: allow connection shutdown callback to be invoked in advance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140305.235618.31002872977881096.davem@davemloft.net>
Date:	Wed, 05 Mar 2014 23:56:18 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	erik.hugne@...csson.com
Cc:	netdev@...r.kernel.org, tipc-discussion@...ts.sourceforge.net,
	jon.maloy@...csson.com, maloy@...jonn.com, ying.xue@...driver.com,
	paul.gortmaker@...driver.com, richard.alpe@...csson.com
Subject: Re: [PATCH net-next v2 1/6] tipc: allow connection shutdown
 callback to be invoked in advance

From: <erik.hugne@...csson.com>
Date: Wed, 5 Mar 2014 08:56:13 +0100

> @@ -413,8 +411,11 @@ int tipc_conn_sendmsg(struct tipc_server *s, int conid,
>  	struct tipc_conn *con;
>  
>  	con = tipc_conn_lookup(s, conid);
> -	if (!con)
> +	if (!con) {
> +		pr_err("Connection %d not found on server %s\n", conid,
> +		       s->name);
>  		return -EINVAL;
> +	}
>  
>  	e = tipc_alloc_entry(data, len);
>  	if (!e) {

You really don't want to add kernel log messages which might be easily
triggerable by the user.  Please remove this.

This is the second such case I've pointed out in this patch set, please
audit the rest of your changes for the same issue before resubmitting
so we don't go into this loop yet another time.

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html