netdev - Re: [PATCH net-next v2 1/6] tipc: allow connection shutdown callback to be invoked in advance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140306090634.GA6630@eerihug-hybrid.rnd.ki.sw.ericsson.se>
Date:	Thu, 6 Mar 2014 10:06:34 +0100
From:	Erik Hugne <erik.hugne@...csson.com>
To:	David Miller <davem@...emloft.net>
CC:	<netdev@...r.kernel.org>, <tipc-discussion@...ts.sourceforge.net>,
	<jon.maloy@...csson.com>, <maloy@...jonn.com>,
	<ying.xue@...driver.com>, <paul.gortmaker@...driver.com>,
	<richard.alpe@...csson.com>
Subject: Re: [PATCH net-next v2 1/6] tipc: allow connection shutdown callback
 to be invoked in advance

On Wed, Mar 05, 2014 at 11:56:18PM -0500, David Miller wrote:
> From: <erik.hugne@...csson.com>
> Date: Wed, 5 Mar 2014 08:56:13 +0100
> 
> > @@ -413,8 +411,11 @@ int tipc_conn_sendmsg(struct tipc_server *s, int conid,
> >  	struct tipc_conn *con;
> >  
> >  	con = tipc_conn_lookup(s, conid);
> > -	if (!con)
> > +	if (!con) {
> > +		pr_err("Connection %d not found on server %s\n", conid,
> > +		       s->name);
> >  		return -EINVAL;
> > +	}
> >  
> >  	e = tipc_alloc_entry(data, len);
> >  	if (!e) {
> 
> You really don't want to add kernel log messages which might be easily
> triggerable by the user.  Please remove this.

Ok i'll remove it, but i'd anyway like to mention that this cannot be triggered
by users. This function is only invoked from the TIPC internal services
(subscriber and config) as a response from network events.

//E
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html