netdev - Re: [PATCH] net: davinci_emac: Replace devm_request_irq with request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+V-a8u3HChveLMuncWmXpeMhFgj1Bj4urLK1-gCOafAd0JxVg@mail.gmail.com>
Date:	Thu, 6 Mar 2014 11:08:18 +0530
From:	Prabhakar Lad <prabhakar.csengg@...il.com>
To:	Christian Riesch <christian.riesch@...cron.at>
Cc:	netdev <netdev@...r.kernel.org>, Jon Ringle <jon@...gle.org>,
	Florian Fainelli <f.fainelli@...il.com>,
	dlos <davinci-linux-open-source@...ux.davincidsp.com>,
	stable@...r.kernel.org
Subject: Re: [PATCH] net: davinci_emac: Replace devm_request_irq with request_irq

Hi Christian,

Thanks for the patch.

On Wed, Mar 5, 2014 at 3:55 PM, Christian Riesch
<christian.riesch@...cron.at> wrote:
> In commit 6892b41d9701283085b655c6086fb57a5d63fa47
>
> Author: Lad, Prabhakar <prabhakar.csengg@...il.com>
> Date:   Tue Jun 25 21:24:51 2013 +0530
> net: davinci: emac: Convert to devm_* api
>
> the call of request_irq is replaced by devm_request_irq and the call
> of free_irq is removed. But since interrupts are requested in
> emac_dev_open, doing ifconfig up/down on the board requests the
> interrupts again each time, causing devm_request_irq to fail.
>
> This patch reverts said commit partially: It changes the driver back
> to use request_irq instead of devm_request_irq, puts free_irq back in
> place, but keeps the remaining changes of the original patch.
>
> Reported-by: Jon Ringle <jon@...gle.org>
> Signed-off-by: Christian Riesch <christian.riesch@...cron.at>
> Cc: Lad, Prabhakar <prabhakar.csengg@...il.com>
> Cc: <stable@...r.kernel.org>

Acked-by: Lad, Prabhakar <prabhakar.csengg@...il.com>

Regards,
--Prabhakar lad
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html