netdev - Re: [PATCH net-next] chelsio: Use more current logging style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140306062020.GC23862@hariprasad-pc>
Date:	Thu, 6 Mar 2014 11:50:21 +0530
From:	Hariprasad S <hariprasad@...lsio.com>
To:	Joe Perches <joe@...ches.com>, <davem@...emloft.net>
CC:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	<netdev@...r.kernel.org>, <kumaras@...lsio.com>, <dm@...lsio.com>,
	<swise@...ngridcomputing.com>, <leedom@...lsio.com>,
	<santosh@...lsio.com>, <nirranjan@...lsio.com>
Subject: Re: [PATCH net-next] chelsio: Use more current logging style

On Tue, Mar 04, 2014 at 11:36:45 -0800, Joe Perches wrote:
> On Tue, 2014-03-04 at 23:22 +0300, Sergei Shtylyov wrote:
> > On 03/04/2014 08:43 PM, Joe Perches wrote:
> > >> From: Kumar Sanghvi <kumaras@...lsio.com>
> > >> +		CH_WARN(adap, "SGE idma%u, queue%u, maybe stuck state%u %dsecs"
> > >> +			" (debug0=%#x, debug11=%#x)\n",
> > > Probably better with the format coalesced:
> > > 		CH_WARN(adap, "SGE idma%u, queue%u, maybe stuck state%u %dsecs (debug0=%#x, debug11=%#x)\n",
> >     Surely better, as otherwise it shouldn't pass scripts/checkpatch.pl.
> 
> It'd complain in any case as CH_<LEVEL> macros are 
> uppercase and checkpatch doesn't know that those are
> logging uses.
> 
> Maybe renaming all the CH_<LEVEL> macros to lower
> case like this would help.
> 
> This also can now use dynamic_debug for the ch_dbg
> statements and removes the CH_MSG function as it's
> unused.
> 
> From: Joe Perches <joe@...ches.com>
> 
> Use more standard style lower case logging macros.
> 
> Coalesce formats
> Remove unnecessary periods
> Enable dynamic debugging and verify debug format/arguments
> 
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
[...] 
> 

I don't see this patch in net-next or in the netdev patchwork queue.
Is the patch lost by any chance? Or I missed something ?


Thanks,
-Hari.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html