netdev - Re: [net-next 03/13] i40e: Flow Director sideband accounting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1394390100.15968.9.camel@deadeye.wl.decadent.org.uk>
Date:	Sun, 09 Mar 2014 18:35:00 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:	davem@...emloft.net,
	Joseph Gasparakis <joseph.gasparakis@...el.com>,
	netdev@...r.kernel.org, gospo@...hat.com, sassmann@...hat.com,
	Anjali Singhai Jain <anjali.singhai@...el.com>,
	Jesse Brandeburg <jesse.brandeburg@...el.com>,
	Catherine Sullivan <catherine.sullivan@...el.com>
Subject: Re: [net-next 03/13] i40e: Flow Director sideband accounting

On Wed, 2014-03-05 at 20:21 -0800, Jeff Kirsher wrote:
[...]
> +static int i40e_get_ethtool_fdir_entry(struct i40e_pf *pf,
> +                                      struct ethtool_rxnfc *cmd)
> +{
> +       struct ethtool_rx_flow_spec *fsp =
> +                       (struct ethtool_rx_flow_spec *)&cmd->fs;
> +       struct i40e_fdir_filter *rule = NULL;
> +       struct hlist_node *node2;
> +
> +       /* report total rule count */
> +       cmd->data = pf->hw.fdir_shared_filter_count +
> +                   pf->fdir_pf_filter_count;

The value of the data field is not defined for ETHTOOL_GRXCLSRULE, so
don't set it here.

[...]
>  	case ETHTOOL_GRXCLSRLCNT:
> -		cmd->rule_cnt = 10;
> +		cmd->rule_cnt = pf->fdir_pf_active_filters;
>  		ret = 0;
>  		break;
[...]

However, ETHTOOL_GRXCLSRLCNT *should* set the data field consistently
with ETHTOOL_GRXCLSRLALL.

Ben.

-- 
Ben Hutchings
I say we take off; nuke the site from orbit.  It's the only way to be sure.

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)