netdev - Re: [PATCH net] igb: Unset IGB_FLAG_HAS_MSIX-flag when falling back to msi-only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140310185009.GB8001@cpaasch-mac>
Date:	Mon, 10 Mar 2014 19:50:09 +0100
From:	"christoph.paasch@...ouvain.be" <christoph.paasch@...ouvain.be>
To:	"Brown, Aaron F" <aaron.f.brown@...el.com>
Cc:	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
	"Wyborny, Carolyn" <carolyn.wyborny@...el.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"e1000-devel@...ts.sourceforge.net" 
	<e1000-devel@...ts.sourceforge.net>,
	"davem@...emloft.net" <davem@...emloft.net>
Subject: Re: [PATCH net] igb: Unset IGB_FLAG_HAS_MSIX-flag when falling back
 to msi-only

Hello Aaron,

On 19/02/14 - 00:05:30, Brown, Aaron F wrote:
> On Wed, 2014-02-19 at 00:36 +0100, Christoph Paasch wrote:
> > rior to cd14ef54d25 (igb: Change to use statically allocated array for
> > MSIx entries), having msix_entries different from NULL was an
> > indicator
> > that MSIX is enabled.
> > In igb_set_interrupt_capabiliy we may fall back to MSI-only. Prior to
> > the above patch msix_entries was set to NULL by
> > igb_reset_interrupt_capability.
> > 
> > However, now we are checking the flag for IGB_FLAG_HAS_MSIX and so the
> > stack gets completly confused:
> > 
> > [   42.659791] ------------[ cut here ]------------
> > <snip>
> 
> > [   47.892146] handlers:
> > [   47.919301] [<ffffffff812fbd7d>] igb_intr
> > 
> > So, this patch unsets the flag to indicate that we are not using MSIX.
> > This patch does exactly this: Unsetting the flag when falling back to
> > MSI.
> > 
> > Fixes: cd14ef54d25b (igb: Change to use statically allocated array for
> > MSIx entries)
> > Cc: Carolyn Wyborny <carolyn.wyborny@...el.com>
> > Signed-off-by: Christoph Paasch <christoph.paasch@...ouvain.be>
> > ---
> >  drivers/net/ethernet/intel/igb/igb_main.c | 1 +
> >  1 file changed, 1 insertion(+) 
> 
> Thanks Christoph, I have added this to our Jeff's internal queue as
> well.

are the patches in Jeff's queue?
Because, in his last pull request they were not part of it.

I think these patches should make it into 3.14, because my machines are not
booting because of these issues.


Cheers,
Christoph

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html