netdev - Re: [PATCH net-next] tcp: timestamp SYN+DATA messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK6E8=d_H3y4aKwASi==mdc2_Wv4QkNsekoyU7ZCx2S1HRVcqA@mail.gmail.com>
Date:	Mon, 10 Mar 2014 11:49:54 -0700
From:	Yuchung Cheng <ycheng@...gle.com>
To:	Neal Cardwell <ncardwell@...gle.com>
Cc:	Eric Dumazet <eric.dumazet@...il.com>,
	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] tcp: timestamp SYN+DATA messages

On Mon, Mar 10, 2014 at 9:22 AM, Neal Cardwell <ncardwell@...gle.com> wrote:
> On Sun, Mar 9, 2014 at 8:36 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
>> From: Eric Dumazet <edumazet@...gle.com>
>>
>> All skb in socket write queue should be properly timestamped.
>>
>> In case of FastOpen, we special case the SYN+DATA 'message' as we
>> queue in socket wrote queue the two fallback skbs:
>>
>> 1) SYN message by itself.
>> 2) DATA segment by itself.
>>
>> We should make sure these skbs have proper timestamps.
>>
>> Add a WARN_ON_ONCE() to eventually catch future violations.
>>
>> Fixes: 740b0f1841f6 ("tcp: switch rtt estimations to usec resolution")
>> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
>> Cc: Neal Cardwell <ncardwell@...gle.com>
>> Cc: Yuchung Cheng <ycheng@...gle.com>
>
> Acked-by: Neal Cardwell <ncardwell@...gle.com>
Acked-by: Yuchung Cheng <ycheng@...gle.com>

>
> neal
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html