netdev - Re: [PATCH net-next] pkt_sched: add cond_resched() to class and qdisc dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140310.153205.851677230247140352.davem@davemloft.net>
Date:	Mon, 10 Mar 2014 15:32:05 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] pkt_sched: add cond_resched() to class and
 qdisc dump

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 07 Mar 2014 18:01:04 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> We have seen delays of more than 50ms in class or qdisc dumps, in case
> device is under high TX stress.
> 
> Add cond_resched() to give a chance to higher prio tasks to get cpu.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Is it OK to sleep (or rather: cond_resched()) in an RCU region?
That's what will potentially happen via tc_dump_qdisc() it seems.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html