netdev - Re: [PATCH net-next] pkt_sched: add cond_resched() to class and qdisc dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1394482344.3607.58.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Mon, 10 Mar 2014 13:12:24 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] pkt_sched: add cond_resched() to class and
 qdisc dump

On Mon, 2014-03-10 at 15:32 -0400, David Miller wrote:

> Is it OK to sleep (or rather: cond_resched()) in an RCU region?
> That's what will potentially happen via tc_dump_qdisc() it seems.

Hmpf, you are right I forgot this.

RTNL protects us in tc_dump_qdisc().

I need to remove this useless rcu protection.

Thanks


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html