| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140310124303.165fc8b3@nehalam.linuxnetplumber.net> Date: Mon, 10 Mar 2014 12:43:03 -0700 From: Stephen Hemminger <stephen@...workplumber.org> To: Shahed Shaikh <shahed.shaikh@...gic.com> Cc: <davem@...emloft.net>, <netdev@...r.kernel.org>, <Dept-HSGLinuxNICDev@...gic.com> Subject: Re: [PATCH net-next 1/5] vxlan: Make VXLAN default UDP port number available for others On Mon, 10 Mar 2014 12:48:58 -0400 Shahed Shaikh <shahed.shaikh@...gic.com> wrote: > From: Shahed Shaikh <shahed.shaikh@...gic.com> > > Although vxlan module has capability to notify udp ports to > other interested net devices using .ndo_add_rx_vxlan_port and > .ndo_del_rx_vxlan_port, there could be some devices which support > vxlan offload but not interested in updating udp port numbers. > This may be because some hardware do not support programming multiple > udp ports and their drivers may decide to program only default udp port > into adapter. So that adapter, at least, can do offloading for > default udp port number. > > Signed-off-by: Shahed Shaikh <shahed.shaikh@...gic.com> Rather than compiling in the value, it makes more sense to make the default port variable in vxlan driver exported. That way if user overrides it with a module parameter the offload will still work. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists