netdev - Re: [PATCHv5 net-next 15/31] iw_cxgb4: save the correct map length for fast_reg_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <531E23E9.4030702@cogentembedded.com>
Date:	Mon, 10 Mar 2014 23:43:21 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Hariprasad Shenai <hariprasad@...lsio.com>, netdev@...r.kernel.org,
	linux-rdma@...r.kernel.org
CC:	davem@...emloft.net, roland@...estorage.com, dm@...lsio.com,
	swise@...ngridcomputing.com, leedom@...lsio.com,
	santosh@...lsio.com, kumaras@...lsio.com, nirranjan@...lsio.com
Subject: Re: [PATCHv5 net-next 15/31] iw_cxgb4: save the correct map length
 for fast_reg_page_lists

Hello.

On 03/10/2014 08:08 PM, Hariprasad Shenai wrote:

> From: Steve Wise <swise@...ngridcomputing.com>

> We cannot save the mapped length using the rdma max_page_list_len field
> of the ib_fast_reg_page_list struct because the core code uses it.  This
> results in an incorrect unmap of the page list in c4iw_free_fastreg_pbl().

> I found this with dma map debugging enabled in the kernel.  The fix is
> to save the length in the c4iw_fr_page_list struct.

> Signed-off-by: Steve Wise <swise@...ngridcomputing.com>
> ---
>   drivers/infiniband/hw/cxgb4/iw_cxgb4.h |  1 +
>   drivers/infiniband/hw/cxgb4/mem.c      | 12 ++++++++++--
>   2 files changed, 11 insertions(+), 2 deletions(-)

> diff --git a/drivers/infiniband/hw/cxgb4/iw_cxgb4.h b/drivers/infiniband/hw/cxgb4/iw_cxgb4.h
> index 8c32088..b75f8f5 100644
> --- a/drivers/infiniband/hw/cxgb4/iw_cxgb4.h
> +++ b/drivers/infiniband/hw/cxgb4/iw_cxgb4.h
> @@ -375,6 +375,7 @@ struct c4iw_fr_page_list {
>   	DEFINE_DMA_UNMAP_ADDR(mapping);
>   	dma_addr_t dma_addr;
>   	struct c4iw_dev *dev;
> +	int pll_len;
>   };
>
>   static inline struct c4iw_fr_page_list *to_c4iw_fr_page_list(
> diff --git a/drivers/infiniband/hw/cxgb4/mem.c b/drivers/infiniband/hw/cxgb4/mem.c
> index 41b1195..cdaf257 100644
> --- a/drivers/infiniband/hw/cxgb4/mem.c
> +++ b/drivers/infiniband/hw/cxgb4/mem.c
> @@ -903,7 +903,11 @@ struct ib_fast_reg_page_list *c4iw_alloc_fastreg_pbl(struct ib_device *device,
>   	dma_unmap_addr_set(c4pl, mapping, dma_addr);
>   	c4pl->dma_addr = dma_addr;
>   	c4pl->dev = dev;
> -	c4pl->ibpl.max_page_list_len = pll_len;
> +	c4pl->pll_len = pll_len;
> +
> +	PDBG("%s c4pl %p pll_len %u page_list %p dma_addr %p\n",
> +	     __func__, c4pl, c4pl->pll_len, c4pl->ibpl.page_list,
> +	     (void *)c4pl->dma_addr);

    There's %pad format for printing dma_addr_t, no need to cast and use %p.

>
>   	return &c4pl->ibpl;
>   }
> @@ -912,8 +916,12 @@ void c4iw_free_fastreg_pbl(struct ib_fast_reg_page_list *ibpl)
>   {
>   	struct c4iw_fr_page_list *c4pl = to_c4iw_fr_page_list(ibpl);
>
> +	PDBG("%s c4pl %p pll_len %u page_list %p dma_addr %p\n",
> +	     __func__, c4pl, c4pl->pll_len, c4pl->ibpl.page_list,
> +	     (void *)c4pl->dma_addr);
> +

    Likewise.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html