netdev - Re: [PATCH net] pkt_sched: move the sanity test in qdisc_list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140310.154443.2004305018874618616.davem@davemloft.net>
Date:	Mon, 10 Mar 2014 15:44:43 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	Valdis.Kletnieks@...edu, mt-ml@....de, edumazet@...gle.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH net] pkt_sched: move the sanity test in qdisc_list_add()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Sat, 08 Mar 2014 08:01:19 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> The WARN_ON(root == &noop_qdisc)) added in qdisc_list_add()
> can trigger in normal conditions when devices are not up.
> It should be done only right before the list_add_tail() call.
> 
> Fixes: e57a784d8cae4 ("pkt_sched: set root qdisc before change() in attach_default_qdiscs()")
> Reported-by: Valdis Kletnieks <Valdis.Kletnieks@...edu>
> Tested-by: Mirco Tischler <mt-ml@....de>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html