netdev - Re: [PATCH net-next v3 5/9] Altera TSE: Add Miscellaneous Files for Altera Ethernet Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOwfj2Ot+ssTZgMoOoShVEUi+RkxjpPpRUfHAkP9RETm3TuUzg@mail.gmail.com>
Date:	Tue, 11 Mar 2014 19:28:53 -0500
From:	Vince Bridgers <vbridgers2013@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	"pawel.moll@....com" <pawel.moll@....com>,
	"mark.rutland@....com" <mark.rutland@....com>,
	"ijc+devicetree@...lion.org.uk" <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Rob Landley <rob@...dley.net>
Subject: Re: [PATCH net-next v3 5/9] Altera TSE: Add Miscellaneous Files for
 Altera Ethernet Driver

Hi Joe,

On Tue, Mar 11, 2014 at 5:59 PM, Joe Perches <joe@...ches.com> wrote:
> On Tue, 2014-03-11 at 17:43 -0500, Vince Bridgers wrote:
>> This patch adds miscellaneous files for the Altera Ethernet Driver,
>> including ethtool support.
>
> trivial notes:
>
>> diff --git a/drivers/net/ethernet/altera/altera_tse_ethtool.c b/drivers/net/ethernet/altera/altera_tse_ethtool.c
> []
>> +static char const stat_gstrings[][ETH_GSTRING_LEN] = {
>
> static const char
>
>> +     "aFramesTransmittedOK",
>
> Why the prefix with a?

These names follow the names of the statistics found in the databook
for the Altera Triple Speed Ethernet (TSE) soft IP. I'm not
emotionally attached to these names, so will review the statistics
names and follow common usage instead. Thank you for noticing and
commenting.

>
>> +     "aFramesReceivedOK",
>
> "rx_packets" is typically used
>
>> +     "aFramesCheckSequenceErrors",
>
>> +     "aAlignmentErrors",
>> +     "aOctetsTransmittedOK",
>> +     "aOctetsReceivedOK",
>> +     "aTxPAUSEMACCtrlFrames",
>> +     "aRxPAUSEMACCtrlFrames",
>> +     "ifInErrors",
>> +     "ifOutErrors",
>> +     "ifInUcastPkts",
>> +     "ifInMulticastPkts",
>> +     "ifInBroadcastPkts",
>> +     "ifOutDiscards",
>> +     "ifOutUcastPkts",
>> +     "ifOutMulticastPkts",
>> +     "ifOutBroadcastPkts",
>> +     "etherStatsDropEvents",
>> +     "etherStatsOctets",
>> +     "etherStatsPkts",
>> +     "etherStatsUndersizePkts",
>> +     "etherStatsOversizePkts",
>> +     "etherStatsPkts64Octets",
>> +     "etherStatsPkts65to127Octets",
>> +     "etherStatsPkts128to255Octets",
>> +     "etherStatsPkts256to511Octets",
>> +     "etherStatsPkts512to1023Octets",
>> +     "etherStatsPkts1024to1518Octets",
>> +     "etherStatsPkts1519toXOctets",
>> +     "etherStatsJabbers",
>> +     "etherStatsFragments",
>
> Perhaps review all of these strings for
> unusual naming.

Will do, thanks.

>
>> +static void tse_get_regs(struct net_device *dev, struct ethtool_regs *regs,
>> +                      void *regbuf)
>> +{
>> +     int i;
>> +     struct altera_tse_private *priv = netdev_priv(dev);
>> +     u32 *tse_mac_regs = (u32 *)priv->mac_dev;
>> +     u32 *buf = (u32 *)regbuf;
>
> void * doesn't need a cast
>
>         u32 *buf = regbuf
>
> is just fine.

I'll pick this up while reviewing and updating the stats names.

Thank you for taking the time to review and provide constructive
comments. I'll address these and respin.

All the best,

Vince
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html