netdev - Re: [PATCH net-next v3 6/9] Altera TSE: Add main and header file for Altera Ethernet Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1394585144.28839.32.camel@joe-AO722>
Date:	Tue, 11 Mar 2014 17:45:44 -0700
From:	Joe Perches <joe@...ches.com>
To:	Vince Bridgers <vbridgers2013@...il.com>
Cc:	devicetree@...r.kernel.org, netdev@...r.kernel.org,
	linux-doc@...r.kernel.org, robh+dt@...nel.org, pawel.moll@....com,
	mark.rutland@....com, ijc+devicetree@...lion.org.uk,
	galak@...eaurora.org, rob@...dley.net
Subject: Re: [PATCH net-next v3 6/9] Altera TSE: Add main and header file
 for Altera Ethernet Driver

On Tue, 2014-03-11 at 17:43 -0500, Vince Bridgers wrote:
> This patch adds the main driver and header file for the Altera Triple
> Speed Ethernet driver.

trivial notes about message logging:

> diff --git a/drivers/net/ethernet/altera/altera_tse_main.c b/drivers/net/ethernet/altera/altera_tse_main.c
[]
> +static const u32 default_msg_level = (NETIF_MSG_DRV | NETIF_MSG_PROBE |
> +					NETIF_MSG_LINK | NETIF_MSG_IFUP |
> +					NETIF_MSG_IFDOWN);
[]
> +static int altera_tse_mdio_create(struct net_device *dev, unsigned int id)
> +{
[]
> +	mdio->irq = kcalloc(PHY_MAX_ADDR, sizeof(int), GFP_KERNEL);
> +	if (mdio->irq == NULL) {
> +		dev_err(priv->device, "%s: Cannot allocate memory\n", __func__);

OOM messages aren't necessary as all allocs have
a generic OOM message as well as a dump_stack();
(well, any alloc without GFP_NOWARN)

> +	ret = of_mdiobus_register(mdio, mdio_node);
> +	if (ret != 0) {
> +		dev_err(priv->device, "Cannot register MDIO bus %s\n",
> +			mdio->id);

Because you have a struct net_device * available,
you should probably use that.

		netdev_err(dev, "Cannot register MDIO bus %s\n", mdio->id);

> +		goto out_free_mdio_irq;
> +	}
> +
> +	if (netif_msg_drv(priv))
> +		dev_info(priv->device, "MDIO bus %s: created\n", mdio->id);

There are generic functions for this with the struct net_device *

	netif_info(priv, drv, dev, "MDIO bus %s: created\n", mdio->id);

> +static void altera_tse_mdio_destroy(struct net_device *dev)
> +{
[]
> +	if (netif_msg_drv(priv))
> +		dev_info(priv->device, "MDIO bus %s: removed\n",
> +			 priv->mdio->id);

	netif_info(priv, drv, dev, "MDIO bus %s: removed\n, priv->mdio->id);

[]

> +static int tse_init_rx_buffer(struct altera_tse_private *priv,
> +			      struct tse_buffer *rxbuffer, int len)
> +{
> +	rxbuffer->skb = netdev_alloc_skb_ip_align(priv->dev, len);
> +	if (!rxbuffer->skb) {
> +		dev_err(priv->device, "%s: Rx init fails; skb is NULL\n",
> +			__func__);

		netdev_err(priv->dev, "%s: etc...)

but this is also a generic alloc and will get the same generic OOM.

> +	if (dma_mapping_error(priv->device, rxbuffer->dma_addr)) {
> +		dev_err(priv->device, "%s: DMA mapping error\n", __func__);

		netdev_err(priv->dev, etc...)

etc...

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html