netdev - The ssthresh reduce during 3WHS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 12 Mar 2014 21:46:04 +0800
From:	Yong Zhang <fell198904@...il.com>
To:	netdev@...r.kernel.org
Cc:	Yong Zhang <fell198904@...il.com>
Subject: The ssthresh reduce during 3WHS

hi，

I am trying to to apply patch 9ad7c049f0f79c418e293b1b68cf10d68f54fcdb
to my old version kernel, but I am not understanding the following
changes.

The comments int the patch say ssthresh may reduce unnecessarily
druing 3WHS,  but i can not find the reduce operation of ssthresh
during 3WHS.

Can you please explain when dose this may hanppen?


diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index bef9f04..ea0d218 100644
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -880,6 +880,11 @@ static void tcp_init_metrics(struct sock *sk)

        tp->snd_ssthresh = dst_metric(dst, RTAX_SSTHRESH);
                 if (tp->snd_ssthresh > tp->snd_cwnd_clamp)
                         tp->snd_ssthresh = tp->snd_cwnd_clamp;
+       } else {
+                /* ssthresh may have been reduced unnecessarily during.
+                * 3WHS. Restore it back to its initial default.
+                */
+                tp->snd_ssthresh = TCP_INFINITE_SSTHRESH;
         }


Thanks,
Fel
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html