netdev - Re: [PATCH next-next 0/10] Using dev_kfree_skb_any for functions called in multiple contexts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1394592845.21721.38.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Tue, 11 Mar 2014 19:54:05 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	xiyou.wangcong@...il.com, mpm@...enic.com, satyam.sharma@...il.com
Subject: Re: [PATCH next-next 0/10] Using dev_kfree_skb_any for functions
 called in multiple contexts

On Tue, 2014-03-11 at 14:13 -0700, Eric W. Biederman wrote:
> This patchset should be an uncontroversial set of changes to change
> dev_kfree_skb to dev_kfree_skb_any for code paths that are called in
> hard irq contexts in addition to other contexts.  netpoll is the reason
> this code gets called in multiple contexts.
> 
> There is more coming but these changes are a good starting place, and
> stand on their own.
> 
> Since the last round changes to the rx path have been removed netpoll
> will changed to avoid that.
> 
> Eric W. Biederman (10):
>       8139cp: Call dev_kfree_skby_any instead of kfree_skb.
>       8139too: Call dev_kfree_skby_any instead of dev_kfree_skb.
>       r8169: Call dev_kfree_skby_any instead of dev_kfree_skb.
>       bonding: Call dev_kfree_skby_any instead of kfree_skb.
>       bnx2: Call dev_kfree_skby_any instead of dev_kfree_skb.
>       tg3: Call dev_kfree_skby_any instead of dev_kfree_skb.
>       ixgb: Call dev_kfree_skby_any instead of dev_kfree_skb.
>       mlx4: Call dev_kfree_skby_any instead of dev_kfree_skb.
>       benet: Call dev_kfree_skby_any instead of kfree_skb.
>       gianfar: Carefully free skbs in functions called by netpoll.

Acked-by: Eric Dumazet <edumazet@...gle.com>

We'll have some follow up, but these patches seem fine.
 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html