netdev - Re: [PATCH net-next 02/10] 8139too: Call dev_kfree_skby_any instead of dev_kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1394589986.21721.37.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Tue, 11 Mar 2014 19:06:26 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	xiyou.wangcong@...il.com, mpm@...enic.com, satyam.sharma@...il.com
Subject: Re: [PATCH net-next 02/10] 8139too: Call dev_kfree_skby_any instead
 of dev_kfree_skb.

On Tue, 2014-03-11 at 14:15 -0700, Eric W. Biederman wrote:
> Replace dev_kfree_skb with dev_kfree_skb_any in functions that can
> be called in hard irq and other contexts.
> 
> Signed-off-by: "Eric W. Biederman" <ebiederm@...ssion.com>
> ---
>  drivers/net/ethernet/realtek/8139too.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/realtek/8139too.c b/drivers/net/ethernet/realtek/8139too.c
> index da5972eefdd2..8cb2f357026e 100644
> --- a/drivers/net/ethernet/realtek/8139too.c
> +++ b/drivers/net/ethernet/realtek/8139too.c
> @@ -1717,9 +1717,9 @@ static netdev_tx_t rtl8139_start_xmit (struct sk_buff *skb,
>  		if (len < ETH_ZLEN)
>  			memset(tp->tx_buf[entry], 0, ETH_ZLEN);
>  		skb_copy_and_csum_dev(skb, tp->tx_buf[entry]);
> -		dev_kfree_skb(skb);
> +		dev_kfree_skb_any(skb);
>  	} else {
> -		dev_kfree_skb(skb);
> +		dev_kfree_skb_any(skb);
>  		dev->stats.tx_dropped++;
>  		return NETDEV_TX_OK;
>  	}

Same u64_stats_fetch_begin_bh() problem for this driver to fetch TX
stats.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html