netdev - Re: [Patch 1/2] IB/mlx5: Implementation of PCI error handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1394649252.23624.36.camel@deadeye.wl.decadent.org.uk>
Date:	Wed, 12 Mar 2014 18:34:12 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	clsoto@...ux.vnet.ibm.com
Cc:	eli@...lanox.com, roland@...nel.org, sean.hefty@...el.com,
	hal.rosenstock@...il.com, linux-rdma@...r.kernel.org,
	netdev@...r.kernel.org, brking@...ux.vnet.ibm.com
Subject: Re: [Patch 1/2] IB/mlx5: Implementation of PCI error handler

On Tue, 2014-03-11 at 22:42 -0500, clsoto@...ux.vnet.ibm.com wrote:
[...]
> Index: b/include/linux/mlx5/driver.h
> ===================================================================
> --- a/include/linux/mlx5/driver.h
> +++ b/include/linux/mlx5/driver.h
> @@ -51,10 +51,10 @@ enum {
>  };
>  
>  enum {
> -       /* one minute for the sake of bringup. Generally, commands must always
> +       /* 10 msecs for the sake of bringup. Generally, commands must always
>          * complete and we may need to increase this timeout value
>          */
> -       MLX5_CMD_TIMEOUT_MSEC   = 7200 * 1000,
> +       MLX5_CMD_TIMEOUT_MSEC   = 10 * 1000,

You seem to be changing the timeout from 2 hours (not one minute) to 10
seconds (not milliseconds).

Ben.

>         MLX5_CMD_WQ_MAX_NAME    = 32,
>  };
>  
> 

-- 
Ben Hutchings
Any sufficiently advanced bug is indistinguishable from a feature.

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)