netdev - Re: [PATCHv2 1/2] bridge: multicast: add sanity check for general query destination

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1394649270.23624.37.camel@deadeye.wl.decadent.org.uk>
Date:	Wed, 12 Mar 2014 18:34:30 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Linus Lüssing <linus.luessing@....de>
Cc:	netdev@...r.kernel.org, bridge@...ts.linux-foundation.org,
	Stephen Hemminger <stephen@...workplumber.org>,
	"David S. Miller" <davem@...emloft.net>,
	linux-kernel@...r.kernel.org, Jan Stancek <jstancek@...hat.com>,
	Florian Westphal <fwestpha@...hat.com>
Subject: Re: [PATCHv2 1/2] bridge: multicast: add sanity check for general
 query destination

On Mon, 2014-03-10 at 22:25 +0100, Linus Lüssing wrote:
> General IGMP and MLD queries are supposed to have the multicast
> link-local all-nodes address as their destination according to RFC2236
> section 9, RFC3376 section 4.1.12/9.1, RFC2710 section 8 and RFC3810
> section 5.1.15.
[...]

That reminds me, shouldn't we also check this in igmp_rcv()?

Ben.

-- 
Ben Hutchings
Any sufficiently advanced bug is indistinguishable from a feature.

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)