netdev - Re: [net-next 05/13] igb: Add support for debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140312.162410.1250724491800391563.davem@davemloft.net>
Date:	Wed, 12 Mar 2014 16:24:10 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	carolyn.wyborny@...el.com
Cc:	or.gerlitz@...il.com, jeffrey.t.kirsher@...el.com,
	gospo@...hat.com, netdev@...r.kernel.org, sassmann@...hat.com,
	hayja@...l.uc.edu, amirv@...lanox.com, yevgenyp@...lanox.com
Subject: Re: [net-next 05/13] igb: Add support for debugfs

From: "Wyborny, Carolyn" <carolyn.wyborny@...el.com>
Date: Wed, 12 Mar 2014 20:13:53 +0000

>> -----Original Message-----
>> From: David Miller [mailto:davem@...emloft.net]
>> Sent: Wednesday, March 12, 2014 12:47 PM
>> To: Wyborny, Carolyn
>> Cc: or.gerlitz@...il.com; Kirsher, Jeffrey T; gospo@...hat.com;
>> netdev@...r.kernel.org; sassmann@...hat.com; hayja@...l.uc.edu;
>> amirv@...lanox.com; yevgenyp@...lanox.com
>> Subject: Re: [net-next 05/13] igb: Add support for debugfs
>> 
>> From: "Wyborny, Carolyn" <carolyn.wyborny@...el.com>
>> Date: Wed, 12 Mar 2014 16:35:49 +0000
>> 
>> > Josh and I tried very hard to not reimplement anything already
>> > available in some other tool or mechanism and used the examples we
>> > already have for this in our other drivers.  That being said, we'll
>> > abide and follow any clear criteria provided.
>> 
>> I don't think what's being done here is appropriate.
>> 
>> ethtool can provide the extended statistics.
>> 
>> We already have a way to dump registers in ethtool as well.  If you want to add
>> fine-grained register read support and write support, that would be a nice
>> addition to ethtool.
> 
> Ok, I'll remove the register outputs.  Is there any objection to the other functionality provided?

I said the statistics can be done with ethtool, so I object to everything.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html