netdev - Re: [PATCH net-next v3 5/9] Altera TSE: Add Miscellaneous Files for Altera Ethernet Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1394658856.20857.7.camel@deadeye.wl.decadent.org.uk>
Date:	Wed, 12 Mar 2014 21:14:16 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Vince Bridgers <vbridgers2013@...il.com>
Cc:	Joe Perches <joe@...ches.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	"pawel.moll@....com" <pawel.moll@....com>,
	"mark.rutland@....com" <mark.rutland@....com>,
	"ijc+devicetree@...lion.org.uk" <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Rob Landley <rob@...dley.net>
Subject: Re: [PATCH net-next v3 5/9] Altera TSE: Add Miscellaneous Files for
 Altera Ethernet Driver

On Tue, 2014-03-11 at 19:28 -0500, Vince Bridgers wrote:
> Hi Joe,
> 
> On Tue, Mar 11, 2014 at 5:59 PM, Joe Perches <joe@...ches.com> wrote:
> > On Tue, 2014-03-11 at 17:43 -0500, Vince Bridgers wrote:
> >> This patch adds miscellaneous files for the Altera Ethernet Driver,
> >> including ethtool support.
> >
> > trivial notes:
> >
> >> diff --git a/drivers/net/ethernet/altera/altera_tse_ethtool.c b/drivers/net/ethernet/altera/altera_tse_ethtool.c
> > []
> >> +static char const stat_gstrings[][ETH_GSTRING_LEN] = {
> >
> > static const char
> >
> >> +     "aFramesTransmittedOK",
> >
> > Why the prefix with a?
> 
> These names follow the names of the statistics found in the databook
> for the Altera Triple Speed Ethernet (TSE) soft IP. I'm not
> emotionally attached to these names, so will review the statistics
> names and follow common usage instead. Thank you for noticing and
> commenting.
[...]

These look like the statistic names specified in IEEE 802.3.  I would
support a general move to using standard names for MAC stats in Ethernet
drivers, because they are quite clearly defined and widely implemented
in hardware.  However, that is not the current practice in most Linux
drivers.

Ben.

-- 
Ben Hutchings
Any sufficiently advanced bug is indistinguishable from a feature.

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)