netdev - Re: [PATCH] ipv6: Avoid unnecessary temporary addresses being generated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5320CE98.6010701@web.de>
Date:	Wed, 12 Mar 2014 22:16:08 +0100
From:	Heiner Kallweit <heiner.kallweit@....de>
To:	David Miller <davem@...emloft.net>
CC:	netdev@...r.kernel.org
Subject: Re: [PATCH] ipv6: Avoid unnecessary temporary addresses being generated

You're right. Fixed it and submitted v2 of patch.

> From: Heiner Kallweit <heiner.kallweit@....de>
> Date: Wed, 12 Mar 2014 20:53:48 +0100
>
>> @@ -1103,8 +1103,11 @@ retry:
>>  	 * Lifetime is greater than REGEN_ADVANCE time units.  In particular,
>>  	 * an implementation must not create a temporary address with a zero
>>  	 * Preferred Lifetime.
>> +	 * Use age calculation as in addrconf_verify to avoid unnecessary
>> +	 * temporary addresses being generated.
>>  	 */
>> -	if (tmp_prefered_lft <= regen_advance) {
>> +	age = (now - ifp->tstamp + ADDRCONF_TIMER_FUZZ_MINUS) / HZ;
>> +	if (tmp_prefered_lft <= regen_advance + age) {
> I think you must use tmp_tstamp here, we snapshot all of the values
> above into local variables while holding the lock so that we calculate
> a consistent set of values and tests.
>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html