netdev - Re: [PATCH] net: phy: Add support for SMSC/Microchip LAN9303 3-port switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGm1_ksBkGi=QqfOyK1cxebNshjQ3UfKqOAUAsWxw98yHErw-g@mail.gmail.com>
Date:	Wed, 12 Mar 2014 09:47:20 +0100
From:	Yegor Yefremov <yegorslists@...glemail.com>
To:	Florian Fainelli <f.fainelli@...il.com>
Cc:	David Miller <davem@...emloft.net>, Stefan Roese <sr@...x.de>,
	netdev <netdev@...r.kernel.org>, r.meier@...mens.com,
	lukas.stockmann@...mens.com
Subject: Re: [PATCH] net: phy: Add support for SMSC/Microchip LAN9303 3-port switch

On Tue, Mar 11, 2014 at 9:14 PM, Florian Fainelli <f.fainelli@...il.com> wrote:
> 2014-03-11 13:11 GMT-07:00 Yegor Yefremov <yegorslists@...glemail.com>:
>> On Fri, Feb 28, 2014 at 7:00 PM, David Miller <davem@...emloft.net> wrote:
>>> From: Stefan Roese <sr@...x.de>
>>> Date: Fri, 28 Feb 2014 10:32:20 +0100
>>>
>>>> On 27.02.2014 23:02, David Miller wrote:
>>>>> From: Stefan Roese <sr@...x.de>
>>>>> Date: Thu, 27 Feb 2014 10:07:52 +0100
>>>>>
>>>>> Better is to come up with a real, types, interface for programming
>>>>> such devices and providing an implementation of that.
>>>>
>>>> Right. Such a thing would be better. But as Florian already pointed
>>>> out, nothing like this is available in kernel.org right now. Thats the
>>>> reason why I chose to implement this "simple" driver, btw as done in
>>>> drivers/net/phy/spi_ks8995.c.
>>>
>>> When a suitable user facing interface is lacking, you create one
>>> and submit it for review here.  You don't just submit adhoc driver
>>> local stuff.
>>
>> David, what about enabling ethtool to read/write from/to the PHY
>> registers (via passing PHY ID and register number)? I'm trying to get
>> ICplus IP175D running and it has lots of registers, that I would like
>> to look at dynamically.
>
> ethtool does not do that already for Ethernet MACs attached to a
> single Ethernet PHY, so I do not think this would be the right tool
> for this job. Something custom which uses SIOC{G,S}MIIREG might be
> more suited for this as you would have control over the target PHY
> address.
>
> Maybe swconfig needs to be resubmitted again...

It definitely should. Another option were to create a repo (kernel
fork) at GitHub and create a per release branch for swconfig. This way
people can contribute swconfig compatible drivers for different switch
chips. We would have all source at one central place. And when the
decision about final/official switch interface will be made, we would
have 'only' to rewrite the drivers for the final swconfig version.

Yegor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html