netdev - Re: [PATCH V1 net-next 3/7] mlx4: In RoCE allow guests to have multiple GIDS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53201FAB.3040208@mellanox.com>
Date:	Wed, 12 Mar 2014 10:49:47 +0200
From:	Or Gerlitz <ogerlitz@...lanox.com>
To:	David Miller <davem@...emloft.net>
CC:	<netdev@...r.kernel.org>, <roland@...nel.org>,
	<jackm@....mellanox.co.il>, <amirv@...lanox.com>
Subject: Re: [PATCH V1 net-next 3/7] mlx4: In RoCE allow guests to have multiple
 GIDS

On 12/03/2014 07:00, David Miller wrote:
> I hate to be picky like this, but this second function could be improved.
>
> The first function is fine, it's named "get_*" and it really does return
> a value.
>
> But the second one, it's also named "get_*" but it doesn't return the
> stated value.  Instead, it assigns it into a structure.
>
> The return value is always zero, so I suggest you make it return void and
> adjust the name.  Perhaps "fill_in_real_sgid_index", since that states
> explicitly that the value is "filled in" to the passed ah_attr.
sure, will fix, thanks for spotting this small possible improvement
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html