netdev - Re: [PATCH v2] ipv6: Avoid unnecessary temporary addresses being generated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140313.154946.2142259577860056292.davem@davemloft.net>
Date:	Thu, 13 Mar 2014 15:49:46 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	heiner.kallweit@....de
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH v2] ipv6: Avoid unnecessary temporary addresses being
 generated

From: Heiner Kallweit <heiner.kallweit@....de>
Date: Wed, 12 Mar 2014 22:13:19 +0100

> tmp_prefered_lft is an offset to ifp->tstamp, not now. Therefore
> age needs to be added to the condition.
> 
> Age calculation in ipv6_create_tempaddr is different from the one
> in addrconf_verify and doesn't consider ADDRCONF_TIMER_FUZZ_MINUS.
> This can cause age in ipv6_create_tempaddr to be less than the one
> in addrconf_verify and therefore unnecessary temporary address to
> be generated.
> Use age calculation as in addrconf_modify to avoid this.
> 
> Signed-off-by: Heiner Kallweit <heiner.kallweit@....de>

Looks good, applied, thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html