netdev - Re: [PATCH net v2] vlan: Fix lockdep warning when vlan dev handle notification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140313.155230.2146893995359373637.davem@davemloft.net>
Date:	Thu, 13 Mar 2014 15:52:30 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	dingtianhong@...wei.com
Cc:	ben@...adent.org.uk, john.r.fastabend@...el.com, kaber@...sh.net,
	netdev@...r.kernel.org, f.fainelli@...il.com
Subject: Re: [PATCH net v2] vlan: Fix lockdep warning when vlan dev handle
 notification

From: Ding Tianhong <dingtianhong@...wei.com>
Date: Thu, 13 Mar 2014 10:22:18 +0800

> v1->v2: Convert the vlan_netdev_addr_lock_key to an array of eight elements, which
> 	could support to add 8 vlan id on a same vlan dev, I think it is enough for current
> 	scene, because a netdev's name is limited to IFNAMSIZ which could not hold 8 vlan id,
> 	and the vlan dev would not meet the same class key with its real dev.
> 
> 	The new function vlan_dev_get_lockdep_subkey() will return the subkey and make the vlan
> 	dev could get a suitable class key.

I still am not happy with this solution, unfortunately.  Although I do
appreciate your efforts.

I'm going to do some more research into this issue and try to give you
some more constructive, meaningful, feedback.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html