netdev - Re: [PATCH V2 RE-SEND 0/7] add new Samsung SXGbE driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140313.160947.1309757358549172711.davem@davemloft.net>
Date:	Thu, 13 Mar 2014 16:09:47 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	bh74.an@...sung.com
Cc:	netdev@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
	ilho215.lee@...sung.com
Subject: Re: [PATCH V2 RE-SEND 0/7] add new Samsung SXGbE driver

From: Byungho An <bh74.an@...sung.com>
Date: Thu, 13 Mar 2014 15:55:28 +0900

> This is 2nd posting for Samsung SXGbE driver and just re-sending because of
> line wrapping in previous posting.
> 
> Changes since v1:
> - changed name of driver to SXGbE as per Ben's comment
> - squashed Joe's neatening for many stuff in original patches

I'm mostly happy with this driver, but all of those module parameters
have to be removed except for 'debug'.

They duplicate functionality provided by ethtool.

Module parameters are strongly, if not completely, discouraged.  A
suitable generic configuration mechanism, such as ethtool, should
always be used instead.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html