[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-id: <000f01cf40ad$eecf0be0$cc6d23a0$@samsung.com>
Date: Sat, 15 Mar 2014 17:23:17 -0700
From: "Andrew.an" <bh74.an@...sung.com>
To: 'David Miller' <davem@...emloft.net>
Cc: netdev@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
ilho215.lee@...sung.com
Subject: RE: [PATCH V2 RE-SEND 0/7] add new Samsung SXGbE driver
David Miller <davem@...emloft.net> wrote:
> From: Byungho An <bh74.an@...sung.com>
> Date: Thu, 13 Mar 2014 15:55:28 +0900
>
> > This is 2nd posting for Samsung SXGbE driver and just re-sending because
> of
> > line wrapping in previous posting.
> >
> > Changes since v1:
> > - changed name of driver to SXGbE as per Ben's comment
> > - squashed Joe's neatening for many stuff in original patches
>
> I'm mostly happy with this driver, but all of those module parameters
> have to be removed except for 'debug'.
OK, I'll remove them.
>
> They duplicate functionality provided by ethtool.
OK.
>
> Module parameters are strongly, if not completely, discouraged. A
> suitable generic configuration mechanism, such as ethtool, should
> always be used instead.
OK. I'll repost soon.
Thanks
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists