netdev - Re: [PATCH v2] ethtool: allow for a smaller build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 16 Mar 2014 02:24:20 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Florian Fainelli <f.fainelli@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH v2] ethtool: allow for a smaller build

On Thu, 2014-02-27 at 15:43 -0800, Florian Fainelli wrote:
> Introduce a new configure script option: --disable-pretty-dump which will
> disable building the driver specific register, EEPROM and SFP
> pretty printing objects, the saving are:
> 
> ~500 Kbytes on a x86_64 build
> ~337 Kbytes on a arm build
> 
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> ---
> Changes in v2:
> - reworked the small build around the ETHTOOL_ENABLE_PRETTY_DUMP
>   option which is enabled by default

But not if you actually specify the option.

[...]
> --- a/configure.ac
> +++ b/configure.ac
> @@ -30,5 +30,14 @@ dnl Checks for library functions.
>  AC_HEADER_STDC
>  AC_CHECK_FUNCS(socket strtol)
>  
> +dnl Check for options
> +AC_ARG_ENABLE(pretty-dump,
> +	       [  --enable-pretty-dump	  enable registers, EEPROM and SFP pretty dumps (enabled by default)],,

Too many commas there!  The following logic needs to be the third
argument to AC_ARG_ENABLE:

> +	       [if test x$enableval != xno; then
> +			AC_DEFINE(ETHTOOL_ENABLE_PRETTY_DUMP, 1,
> +			[Define this to enable register, EEPROM and SFP pretty dumps.]) enable_prettydump=yes
> +		fi])

And then the fourth argument is for the default, which must set
enable_prettydump=yes.

[...]
> --- a/ethtool.c
> +++ b/ethtool.c
[...]
> @@ -973,13 +979,13 @@ static int dump_eeprom(int geeprom_dump_raw, struct ethtool_drvinfo *info,
>  		fwrite(ee->data, 1, ee->len, stdout);
>  		return 0;
>  	}
> -
> +#ifdef ETHTOOL_ENABL_PRETTY_DUMP
[...]

Typo.

Ben.

-- 
Ben Hutchings
Computers are not intelligent.	They only think they are.

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)