netdev - Re: [E1000-devel] [PATCH net-next] e1000e: fix the build error when PM is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1394787343.2167.48.camel@jtkirshe-mobl>
Date:	Fri, 14 Mar 2014 01:55:43 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Kevin Hao <haokexin@...il.com>
Cc:	e1000-devel@...ts.sourceforge.net, netdev@...r.kernel.org
Subject: Re: [E1000-devel] [PATCH net-next] e1000e: fix the build error when
 PM is disabled

On Fri, 2014-03-14 at 14:57 +0800, Kevin Hao wrote:
> The commit 2800209994f8 (e1000e: Refactor PM flows) changed the
> SET_SYSTEM_SLEEP_PM_OPS to open-coded assignment, but forgot to
> protect them with CONFIG_PM_SLEEP. Then cause the following build
> error when PM is disabled:
> drivers/net/ethernet/intel/e1000e/netdev.c:7079:13:
> error: 'e1000e_pm_suspend' undeclared here (not in a function)
>   .suspend = e1000e_pm_suspend,
>              ^
> drivers/net/ethernet/intel/e1000e/netdev.c:7080:13:
> error: 'e1000e_pm_resume' undeclared here (not in a function)
>   .resume  = e1000e_pm_resume,
>              ^
> drivers/net/ethernet/intel/e1000e/netdev.c:7082:11:
> error: 'e1000e_pm_thaw' undeclared here (not in a function)
>   .thaw  = e1000e_pm_thaw,
>            ^
> 
> Signed-off-by: Kevin Hao <haokexin@...il.com>
> ---
>  drivers/net/ethernet/intel/e1000e/netdev.c | 2 ++
>  1 file changed, 2 insertions(+)

Thanks Kevin, I will add this to my queue.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)