netdev - Re: [PATCH V2 RE-SEND 1/7] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140317095853.27c27f6c@nehalam.linuxnetplumber.net>
Date:	Mon, 17 Mar 2014 09:58:53 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Byungho An <bh74.an@...sung.com>
Cc:	'Francois Romieu' <romieu@...zoreil.com>, netdev@...r.kernel.org,
	linux-samsung-soc@...r.kernel.org, davem@...emloft.net,
	ilho215.lee@...sung.com, siva.kallam@...sung.com,
	vipul.pandya@...sung.com, ks.giri@...sung.com,
	'Joe Perches' <joe@...ches.com>
Subject: Re: [PATCH V2 RE-SEND 1/7] net: sxgbe: add basic framework for
 Samsung 10Gb ethernet driver

On Sun, 16 Mar 2014 20:53:25 -0700
Byungho An <bh74.an@...sung.com> wrote:

> > 
> > They are used but they always point to the same set of methods.
> > Those methods could thus be directly called.  
> Yes, those methods can be called directly.
> But I think it is acceptable for manageability and extension for future.

That argument is only valid if:
 1. you have hardware that will use it but it is not ready.
 2. they will get used in next release (in < 6 mo)

Ths set of indirection has negative cost: it impedes readability, 
has to be maintained, and hurts performance.

One of the principles of agile programming is NOT to build infrastructure
until it is needed. Otherwise you are likely to build it wrong.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html